Skip to content

remove an odd new-line for catch clause #13750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 1 commit into from
Jan 31, 2017
Merged

remove an odd new-line for catch clause #13750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/compiler/emitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1923,7 +1923,6 @@ namespace ts {
}

function emitCatchClause(node: CatchClause) {
writeLine();
const openParenPos = writeToken(SyntaxKind.CatchKeyword, node.pos);
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy Jan 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about single line comments before the catch keyword:

try {

} //ddd
catch (x) { }

Copy link
Copy Markdown
Contributor Author

@gdh1995 gdh1995 Jan 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'll try to solve it.

Updated: The comment seems to have no influence.

write(" ");
writeToken(SyntaxKind.OpenParenToken, openParenPos);
Expand Down