remove an odd new-line for catch clause#13750
Merged
Merged
Conversation
|
Hi @gdh1995, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
mhegazy
suggested changes
Jan 30, 2017
| } | ||
|
|
||
| function emitCatchClause(node: CatchClause) { | ||
| writeLine(); |
Contributor
There was a problem hiding this comment.
what about single line comments before the catch keyword:
try {
} //ddd
catch (x) { }
Contributor
Author
There was a problem hiding this comment.
Oops, I'll try to solve it.
Updated: The comment seems to have no influence.
Contributor
Author
|
@mhegazy Here's my tests:
try {
var a = 1;
var b = 2;
} // a
catch (e) {}And this PR produces: try {
var a = 1;
var b = 2;
} // a
catch (e) { }And without comments: try {
let a = 1;
let b = 2;
}
catch (e) {}try {
var a = 1;
var b = 2;
}
catch (e) { }
try {} // a
catch (e) {}try { } // a
catch (e) { }try {}
catch (e) {}try { }
catch (e) { } |
rbuckton
approved these changes
Jan 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new line has been written by
writeLineOrSpaceinemitTryStatement, so the firstwriteLineinemitCatchClauseis not needed.I think this is a bug because: if I modify
emitTryStatementand make it write a space aftertryblock, I'll get}+\n+ indentation +catch (+ ... - The\nis obviously redundant.