Skip to content

fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with ClangCL toolset #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with ClangCL toolset #495

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc3daed
fix: update llama.cpp submodule with chrono fix
Jah-yee Mar 13, 2026
2484189
Fix: sys.exit(1) runs unconditionally due to indentation bug
Mar 13, 2026
8c04075
fix: add const to y_col pointer in ggml_vec_dot_i2_i8_s_Nx1
Jah-yee Mar 18, 2026
3f70093
fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with Cl…
Jah-yee Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with Cl… 
…angCL toolset

In setup_env.py, the compile() function was passing -DCMAKE_C_COMPILER=clang
and -DCMAKE_CXX_COMPILER=clang++ universally. When building on Windows
using the -T ClangCL toolset flag, explicitly setting the compiler path
confuses CMake and MSBuild, causing configuration to fail.

This fix checks for Windows platform and skips the compiler flags when
building on Windows, since ClangCL toolset handles compiler selection.
  • Loading branch information
@Jah-yee
Jah-yee committed Mar 18, 2026
commit 3f7009396b6a09e4c4d905cbce19ecb43224de45
6 changes: 5 additions & 1 deletion setup_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,11 @@ def compile():
logging.error(f"Arch {arch} is not supported yet")
exit(0)
logging.info("Compiling the code using CMake.")
run_command(["cmake", "-B", "build", *COMPILER_EXTRA_ARGS[arch], *OS_EXTRA_ARGS.get(platform.system(), []), "-DCMAKE_C_COMPILER=clang", "-DCMAKE_CXX_COMPILER=clang++"], log_step="generate_build_files")
# On Windows with ClangCL toolset, don't set compiler flags as they conflict
if platform.system() == "Windows":
run_command(["cmake", "-B", "build", *COMPILER_EXTRA_ARGS[arch], *OS_EXTRA_ARGS.get(platform.system(), [])], log_step="generate_build_files")
else:
run_command(["cmake", "-B", "build", *COMPILER_EXTRA_ARGS[arch], *OS_EXTRA_ARGS.get(platform.system(), []), "-DCMAKE_C_COMPILER=clang", "-DCMAKE_CXX_COMPILER=clang++"], log_step="generate_build_files")
# run_command(["cmake", "--build", "build", "--target", "llama-cli", "--config", "Release"])
run_command(["cmake", "--build", "build", "--config", "Release"], log_step="compile")

Expand Down