Skip to content

fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with ClangCL toolset #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with ClangCL toolset #495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc3daed
fix: update llama.cpp submodule with chrono fix
Jah-yee Mar 13, 2026
2484189
Fix: sys.exit(1) runs unconditionally due to indentation bug
Mar 13, 2026
8c04075
fix: add const to y_col pointer in ggml_vec_dot_i2_i8_s_Nx1
Jah-yee Mar 18, 2026
3f70093
fix: Skip CMAKE_C_COMPILER flags on Windows to avoid conflict with Cl…
Jah-yee Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix: sys.exit(1) runs unconditionally due to indentation bug 
In setup_env.py (line 107) and utils/e2e_benchmark.py (line 23), the
sys.exit(1) was at the same indentation level as 'try', causing it to
run unconditionally after subprocess completes - even when the command
succeeds. This moves sys.exit(1) inside the except block where it
belongs.

Fixes: #447
  • Loading branch information
SparkLabScout committed Mar 13, 2026
commit 248418967ae8fbe5ed97853d762546c8b1f9f023
2 changes: 1 addition & 1 deletion setup_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def run_command(command, shell=False, log_step=None):
subprocess.run(command, shell=shell, check=True)
except subprocess.CalledProcessError as e:
logging.error(f"Error occurred while running command: {e}")
sys.exit(1)
sys.exit(1)

def prepare_model():
_, arch = system_info()
Expand Down
2 changes: 1 addition & 1 deletion utils/e2e_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def run_command(command, shell=False, log_step=None):
subprocess.run(command, shell=shell, check=True)
except subprocess.CalledProcessError as e:
logging.error(f"Error occurred while running command: {e}")
sys.exit(1)
sys.exit(1)

def run_benchmark():
build_dir = os.path.join(os.path.dirname(os.path.dirname(os.path.abspath(__file__))), "build")
Expand Down