samd/boards: Add Seeed XIAO SAMD21 Plus board definition.#19254
samd/boards: Add Seeed XIAO SAMD21 Plus board definition.#19254cumin777 wants to merge 3 commits into
Conversation
Signed-off-by: cumin <13809292481@163.com>
|
Code size report: |
|
What is the difference to the already-supported Seed XIAO SAMD21? I do not find a XIAO SAMD21 Plus board at the Seeed homepage, and the URL in your files points to the already supported device. |
|
It seems that the only substantial change is extending the pins.csv file. That change does not need a new board definition. Instead you can make a PR for the actual board files with the suggested changes. About the actual list I have a few minor comments:
But maybe you have better information and there will be a new version of the XIAO SAMD21 board, like with a button. Then, one could introduce variants. |
Signed-off-by: cumin <13809292481@163.com>
|
Like @robert-hh I am confused that I can't find any other information about this board. @cumin777 I see you seem to work for Seeed, is this a new product that is not yet announced? The board profile in this PR looks OK. I see you have added a board image here: micropython/micropython-media#120 - thanks! Probably my only real suggestion is that we wait until this board is announced before we merge the new profile. |
|
Sorry, I forgot to explain this This is a new board that we will release and publish. Compared with the existing XIAO SAMD21, the main difference is that more MCU resources are exposed on the new board. The URL currently in the files is only a temporary placeholder because the official product page has not been published yet. I will provide the correct URL as soon as the product is officially released. For the pin list comments, thank you. I will revise the pins.csv accordingly and keep it as compact as possible. |
Signed-off-by: cumin <13809292481@163.com>
|
@cumin777 No problems. Please leave another comment once the new board is announced and the product page is online. |
Summary
This PR adds board support for the Seeed XIAO SAMD21 Plus to the
samdport.It introduces a dedicated
SEEED_XIAO_SAMD21_PLUSboard definition with:The goal of this change is to make the board available as a first-class MicroPython target in the
samdport with the correct board-level pin definitions.Testing
The upstream PR branch is intentionally limited to the board-definition files only.
Board-definition correctness was checked by:
ports/samd/boards/SEEED_XIAO_SAMD21_PLUSdefinition filesIn addition, the corresponding development branch used for full board bring-up (
xiao_samd21_plus_support) was tested on hardware with a locally built MicroPython firmware forSEEED_XIAO_SAMD21_PLUS.On that branch, the following sample-based validation was completed successfully:
This PR itself does not include those sample/test files because it is intended to stay minimal for upstream board-definition submission.
Trade-offs and Alternatives
This PR only adds a new board definition and does not modify shared
samdport behavior.The alternative would have been to include additional test scripts and board-specific validation helpers in the same PR, but that would make the upstream submission larger and less focused. Keeping this PR limited to board-definition files makes review easier and avoids mixing bring-up/testing assets with the minimal board support change.
Generative AI
I used generative AI tools when creating this PR, but a human has checked the
code and is responsible for the code and the description above.