samd/boards: Add Seeed XIAO SAMD21 Plus board definition.#19254
Open
cumin777 wants to merge 1 commit into
Open
samd/boards: Add Seeed XIAO SAMD21 Plus board definition.#19254cumin777 wants to merge 1 commit into
cumin777 wants to merge 1 commit into
Conversation
Signed-off-by: cumin <13809292481@163.com>
|
Code size report: |
Contributor
|
What is the difference to the already-supported Seed XIAO SAMD21? I do not find a XIAO SAMD21 Plus board at the Seeed homepage, and the URL in your files points to the already supported device. |
Contributor
|
It seems that the only substantial change is extending the pins.csv file. That change does not need a new board definition. Instead you can make a PR for the actual board files with the suggested changes. About the actual list I have a few minor comments:
But maybe you have better information and there will be a new version of the XIAO SAMD21 board, like with a button. Then, one could introduce variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds board support for the Seeed XIAO SAMD21 Plus to the
samdport.It introduces a dedicated
SEEED_XIAO_SAMD21_PLUSboard definition with:The goal of this change is to make the board available as a first-class MicroPython target in the
samdport with the correct board-level pin definitions.Testing
The upstream PR branch is intentionally limited to the board-definition files only.
Board-definition correctness was checked by:
ports/samd/boards/SEEED_XIAO_SAMD21_PLUSdefinition filesIn addition, the corresponding development branch used for full board bring-up (
xiao_samd21_plus_support) was tested on hardware with a locally built MicroPython firmware forSEEED_XIAO_SAMD21_PLUS.On that branch, the following sample-based validation was completed successfully:
This PR itself does not include those sample/test files because it is intended to stay minimal for upstream board-definition submission.
Trade-offs and Alternatives
This PR only adds a new board definition and does not modify shared
samdport behavior.The alternative would have been to include additional test scripts and board-specific validation helpers in the same PR, but that would make the upstream submission larger and less focused. Keeping this PR limited to board-definition files makes review easier and avoids mixing bring-up/testing assets with the minimal board support change.
Generative AI
I used generative AI tools when creating this PR, but a human has checked the
code and is responsible for the code and the description above.