Refactor PSRAM clock frequency handling#19224
Open
phuzzyday wants to merge 3 commits into
Open
Conversation
Read clock speed before entering direct mode (flash access is unavailable while QMI direct mode is enabled) Signed-off-by: phuzzyday <phuzzyd@yahoo.ca>
|
Code size report: |
Removed blank space Signed-off-by: phuzzyday <phuzzyd@yahoo.ca>
Signed-off-by: phuzzyday <phuzzyd@yahoo.ca>
Contributor
If with failed checks you mean the CI errors, then those are related to your changes. Given what you committed I reckon you probably didn't read Just in case, please read that document. There's all the necessary information to not cause the two CI errors you see here. Also, since the commits have to be altered, please squash those three commits into just one atomic change. You're just making minor modifications to your main change, after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read clock speed before entering direct mode (flash access is unavailable while QMI direct mode is enabled)
Summary
Fix PSRAM init crash when system clock differs from default
Move clock_get_hz() call before QMI direct mode is enabled.
Flash access is unavailable during direct mode, causing a bus fault
on the instruction fetch when clock_configure_undivided is not
in the XIP cache. Confirmed via debugprobe on WeAct RP2350A.
NOTE - Failed Checks are happening in areas of the code far away from what I changed.
Tested on multiple RP2350 boards. (Weact.)
Generative AI
I used generative AI tools when creating this PR, but a human has checked the
code and is responsible for the code and the description above. (earlphilhower)