Skip to content

Adding memory profiling page.#236

Merged
FranFin merged 2 commits into
masterfrom
feature/memory_profiling
Nov 23, 2020
Merged

Adding memory profiling page.#236
FranFin merged 2 commits into
masterfrom
feature/memory_profiling

Conversation

@FranFin
Copy link
Copy Markdown
Contributor

@FranFin FranFin commented Nov 16, 2020

No description provided.

Copy link
Copy Markdown
Contributor

@ralph-lange ralph-lange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice report! It's a bit long in my opinion, but there are some redundancies which can be removed to shorten it. I marked them in my comments.

Comment thread _data/docs.yml
docs:
- concepts/benchmarking

- title: Memory profiling
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to put benchmarking and memory profiling in one menu, What about a joint menu "Analysis"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the analysis is only about the client library and does not cover the middleware, it could even be put into the existing Client Library menu.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It covers the middleware and the RMW, so I'd say it doesn't properly belong to the Client Library section. On the other hand, I like the idea of putting it together with the benchmarking. However, we decided to remove the section and subsection structure, and leave only a few independent sections, same as in the Overview part. Do we want to go through with it or do we prefer to group topics under common sections as it is right now?

Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated
Comment thread _docs/concepts/memo_prof/index.md Outdated

The measurements are conducted on a micro-ROS Client application with a varying number of entities: either publishers/subscribers (1, 5, 10, 15) or client/server (1, 2, 5, 10).

All the tested apps run on top of FreeRTOS and inside of an ESP32 board. The board is connected by either UDP or serial transport to a micro-ROS Agent running on a Linux machine. As explained above, the choice of FreeRTOS has been by virtue of its memory management functionalities, which easily allow to compute the memory used by applications.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the ESP32 can then be omitted in the abstract.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's normal to repeat something that is already said in the Abstract, so I'd leave that. But I definitely took away its previous occurrence.

@FranFin FranFin requested a review from ralph-lange November 17, 2020 06:30
@FranFin FranFin marked this pull request as ready for review November 23, 2020 10:59
@FranFin FranFin merged commit 4cad89b into master Nov 23, 2020
@FranFin FranFin deleted the feature/memory_profiling branch November 23, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants