Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _data/authors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,7 @@ tkolcon:
amx-piap:
name: Alexandre Malki
github: amx-piap
francesca-finocchiaro:
name: Francesca Finocchiaro
github: FranFin
link: github
4 changes: 4 additions & 0 deletions _data/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
docs:
- concepts/benchmarking

- title: Memory profiling
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to put benchmarking and memory profiling in one menu, What about a joint menu "Analysis"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the analysis is only about the client library and does not cover the middleware, it could even be put into the existing Client Library menu.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It covers the middleware and the RMW, so I'd say it doesn't properly belong to the Client Library section. On the other hand, I like the idea of putting it together with the benchmarking. However, we decided to remove the section and subsection structure, and leave only a few independent sections, same as in the Overview part. Do we want to go through with it or do we prefer to group topics under common sections as it is right now?

docs:
- concepts/memo_prof


- title: Core Tutorials
docs:
Expand Down
Binary file added _docs/concepts/memo_prof/3mems.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
211 changes: 211 additions & 0 deletions _docs/concepts/memo_prof/index.md

Large diffs are not rendered by default.

Binary file added _docs/concepts/memo_prof/overall.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added _docs/concepts/memo_prof/pubsub_diagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added _docs/concepts/memo_prof/rmw_history.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added _docs/concepts/memo_prof/servcli.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added _docs/concepts/memo_prof/services_diagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions _includes/docs_nav.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
{% if page.path contains "_docs/concepts" and section.title == "Benchmarking" %}
{% assign should_show_this_menu = true %}
{% endif %}
{% if page.path contains "_docs/concepts" and section.title == "Memory profiling" %}
{% assign should_show_this_menu = true %}
{% endif %}
{% if page.path contains "_docs/tutorials" and section.title contains "Tutorials" %}
{% assign should_show_this_menu = true %}
{% endif %}
Expand Down