Feature/foxy revision#187
Conversation
ralph-lange
left a comment
There was a problem hiding this comment.
Very good work. Thank you for updating the whole tutorials to thoroughly. I also appreciate the renaming of the common section files. I've marked few typos only. We might consider merging the Zephyr emulator tutorial with the core/first_application_rtos/zephyr/ tutorial, just to reduce the number of tutorial. Yet, this should be discussed first and may be performed in a separate PR then.
| To create and flash the firmware, we are going to use the micro-ROS build system. | ||
| You can find the instructions at the micro-ros-build's [README](https://github.com/micro-ROS/micro-ros-build/blob/dashing/micro_ros_setup/README.md). | ||
| For this particular guide, it is necessary yo use the branch `dashing` and the configuration profile `uros_6lowpan`. | ||
| For this particular guide, it is necessary to use the branch `dashing` and the configuration profile `uros_6lowpan`. |
There was a problem hiding this comment.
Should this branch be renamed or copied to include 'Foxy'?
There was a problem hiding this comment.
Hello Ralph, we have been talking about how to manage the two different version dashing and foxy. Francesca has been testing both in order to ensure that everything works following the tutorial step by step, and I think that she has another branch with changes to dashing.
So, what do you think about merging this tutorial in order to have the complete Foxy release (code + tutorials), and then we can work in integrating these Dashing tutorials tested by Francesca with some kind of "selector" where the user can switch between foxy and dashing version.
In a first review there are slightly differences between both: just the URL to code, some docker image names and these kind of things.
What do you think @FranFin @jamoralp?
PD: We have found some critical issues when using Dashing in 20.04 and Foxy in 18.04 because Ubuntu repos have updated Clang-tidy and GCC by some major version steps. So maybe I suggest that we should encourage the user to use the Ubuntu version according the ROS 2 version.
There was a problem hiding this comment.
Very good work. Thank you for updating the whole tutorials to thoroughly. I also appreciate the renaming of the common section files. I've marked few typos only. We might consider merging the Zephyr emulator tutorial with the core/first_application_rtos/zephyr/ tutorial, just to reduce the number of tutorial. Yet, this should be discussed first and may be performed in a separate PR then.
I'd also leave this Zephyr/Zephyr emulator issue for the future. Let's discuss it in the first OFERA meeting and, if we deem it worth the change, we create a separate PR.
Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>
Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>
Changed and migrated to foxy the following tutorials:
Additionally:
_includes/first_application_commonBEFORE MERGE: