Skip to content

Add specific script to build micro-ROS-Agent#159

Merged
pablogs9 merged 4 commits into
foxyfrom
feature/agent_build_script
Jul 24, 2020
Merged

Add specific script to build micro-ROS-Agent#159
pablogs9 merged 4 commits into
foxyfrom
feature/agent_build_script

Conversation

@jamoralp
Copy link
Copy Markdown
Contributor

@jamoralp jamoralp commented Jul 23, 2020 •
edited by pablogs9
Loading

TO-DO before merge:

@jamoralp jamoralp requested review from FranFin and pablogs9 July 23, 2020 10:26
@jamoralp jamoralp mentioned this pull request Jul 23, 2020
Merged
2 tasks
@pablogs9
Copy link
Copy Markdown
Member

pablogs9 commented Jul 24, 2020

Why are CI agent passing? Is the same running the new script as colcon build?

@jamoralp
Copy link
Copy Markdown
Contributor Author

jamoralp commented Jul 24, 2020

Why are CI agent passing? Is the same running the new script as colcon build?

Well, the script (for now) does nothing but invoke colcon build with the appropriate parameters to avoid the compilation of MicroXRCEAgent executable, as we're not using it. That means colcon build will still work as well to compile the micro_ros_agent target.

pablogs9
pablogs9 previously approved these changes Jul 24, 2020
View reviewed changes
@pablogs9 pablogs9 merged commit 722d036 into foxy Jul 24, 2020
@pablogs9 pablogs9 deleted the feature/agent_build_script branch July 24, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@FranFin FranFin Awaiting requested review from FranFin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamoralp @pablogs9