Skip to content

Ref #8285. Updates on Zephyr emulator#154

Merged
FranFin merged 7 commits into
masterfrom
feature/refactor_zephyr_emulator
May 27, 2020
Merged

Ref #8285. Updates on Zephyr emulator#154
FranFin merged 7 commits into
masterfrom
feature/refactor_zephyr_emulator

Conversation

@pablogs9
Copy link
Copy Markdown
Member

Zephyr emulator rework

@pablogs9 pablogs9 requested review from FranFin and ralph-lange April 29, 2020 06:52
@ralph-lange ralph-lange mentioned this pull request Apr 29, 2020
42 tasks
Comment thread _docs/tutorials/advanced/zephyr_emulator/index.md Outdated
Comment thread _docs/tutorials/advanced/zephyr_emulator/index.md Outdated
Comment thread _docs/tutorials/advanced/zephyr_emulator/index.md Outdated
2. **Configure**: configures the downloaded packages with options such as the micro-ROS application, the selected transport layer or the micro-ROS agent IP address (in network transports).
3. **Build**: generates a binary file ready for being loaded in the hardware.
4. **Flash**: load the micro-ROS software in the hardware.
micro-ROS apps for Zephyr emulator are located at `firmware/zephyr_apps/apps`. In order to create a new application, create a new folder containing two files: the app code (inside a `src` folder) and the RMW configuration. You will also need some other Zephyr related files: a `CMakeLists.txt` to define the building process and a `prj.conf` where Zephyr is configured. There is a sample proyect [here](https://github.com/micro-ROS/zephyr_apps/tree/dashing/apps/host_ping_pong), for now, it is ok to copy them.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
micro-ROS apps for Zephyr emulator are located at `firmware/zephyr_apps/apps`. In order to create a new application, create a new folder containing two files: the app code (inside a `src` folder) and the RMW configuration. You will also need some other Zephyr related files: a `CMakeLists.txt` to define the building process and a `prj.conf` where Zephyr is configured. There is a sample proyect [here](https://github.com/micro-ROS/zephyr_apps/tree/dashing/apps/host_ping_pong), for now, it is ok to copy them.
micro-ROS apps for the Zephyr emulator are located at `firmware/zephyr_apps/apps`. In order to create a new application, create a new folder containing two files: the app code (inside a `src` folder) and the RMW configuration. You will also need some other Zephyr related files: a `CMakeLists.txt` to define the building process and a `prj.conf` where Zephyr is configured. You can find a sample project [here](https://github.com/micro-ROS/zephyr_apps/tree/dashing/apps/host_ping_pong). For this tutorial, it is ok to copy them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I liked better when all this was shown rather than explained. I mean, just the commands, and then references to where to find the files content to copy.
I mean, I would use the same text as the old tutorial, with the pushd and popd commands and everything, and only change the way to refer the user to the files content.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can't you make those links cliackable?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread _docs/tutorials/advanced/zephyr_emulator/index.md Outdated
@pablogs9 pablogs9 requested a review from FranFin April 30, 2020 13:54
FranFin
FranFin previously approved these changes Apr 30, 2020
@pablogs9 pablogs9 force-pushed the feature/refactor_zephyr_emulator branch from 93c65df to 808ffb0 Compare May 6, 2020 12:31
@pablogs9 pablogs9 marked this pull request as ready for review May 27, 2020 06:35
FranFin
FranFin previously approved these changes May 27, 2020
pablogs9 and others added 7 commits May 27, 2020 08:48
Zephyr emulator rework
Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>
Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>
Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>
@pablogs9 pablogs9 force-pushed the feature/refactor_zephyr_emulator branch from 229dae5 to 1e10430 Compare May 27, 2020 06:48
@pablogs9 pablogs9 requested a review from FranFin May 27, 2020 06:59
@FranFin FranFin merged commit cabd5ea into master May 27, 2020
@FranFin FranFin deleted the feature/refactor_zephyr_emulator branch May 27, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants