Pull Request template #8476
shortened, moved to comments, removed links
- Loading branch information
commit 408d78ba58879886024d746188436247a18568cb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,21 @@ | ||
| Thank you so much for your PR! To help us review, fill out the form to the best of your ability. Also, please make use of the development guide at http://matplotlib.org/devdocs/devel/index.html | ||
|
|
||
| <!--- Provide a general summary of your changes in the Title above, for example "Raises ValueError on Non-Numeric Input to set_xlim". Please avoid non-descriptive titles such as "Addresses issue #8576"--> | ||
|
|
||
| ## PR Summary | ||
| <!--- Please provide at least 1-2 sentences describing the pull request in detail. Also indicate the type of PR: bug fix or new feature, and documentation or code. --> | ||
|
|
||
| ## Motivation and Context | ||
| <!--- Why is this change required? What problem does it solve? --> | ||
| <!--- If it fixes an open issue, please link to the issue here. --> | ||
|
|
||
| ## PR Checklist | ||
| - [ ] Code is tested using Py.test on Py2 and Py3 | ||
| - [ ] Code is PEP 8 compliant | ||
| - [ ] New features are documented-and have an example if plot related | ||
|
|
||
| - [ ] Documentation is sphinx and numpydoc compliant | ||
| - [ ] major new feature: added an entry to doc/users/whats_new.rst | ||
|
Contributor
There was a problem hiding this comment. "For major new features", and below "For backwards incompatible changes to the API" |
||
| - [ ] change the API in a backward-incompatible way: documented it in doc/api/api_changes.rst | ||
|
|
||
| We understand that PRs can sometimes feel like a guantlet, especially as the reviews start coming in. Please let us know | ||
|
Contributor
There was a problem hiding this comment. gauntlet the line wrapping is a bit weird. |
||
| if the reviews are unclear or the recommended next step is overwhelming, or if you would like help in addressing a reviewer's comments. And please ping us if you've been waiting too long to hear back on your PR! | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's pytest (no dot) these days
it's may be a bit harsh to request testing on both py2 and py3 (plus you also need to check somewhat antique versions of numpy) so I'd just say "unit tests are present" (travis will catch failures anyways) (for example I typically only run tests on py3.6+latest numpy and just let travis tell me if anything else needs to be corrected)