Skip to content

Pull Request template #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 10 commits into from
Apr 14, 2017
Merged

Pull Request template #8476

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e796b3
Merge pull request #20 from matplotlib/master
story645 Apr 13, 2017
17bc9fe
Create PULL_REQUEST_TEMPLATE.md
story645 Apr 13, 2017
90096e0
Update PULL_REQUEST_TEMPLATE.md
story645 Apr 13, 2017
5a96eff
Update PULL_REQUEST_TEMPLATE.md
story645 Apr 13, 2017
f155f56
point to devdocs instead of devel
story645 Apr 13, 2017
341767f
Update PULL_REQUEST_TEMPLATE.md
story645 Apr 13, 2017
408d78b
shortened, moved to comments, removed links
story645 Apr 13, 2017
aabe383
Update PULL_REQUEST_TEMPLATE.md
story645 Apr 13, 2017
adbc03f
language tidying
story645 Apr 13, 2017
4bf429b
Update PULL_REQUEST_TEMPLATE.md
story645 Apr 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update PULL_REQUEST_TEMPLATE.md
  • Loading branch information
@story645
story645 authored Apr 13, 2017
commit 341767f406c776dd5f40bded8e15f1a8cb487aef
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ Thank you so much for your PR! To help us review, please make use of our
[development guide](http://matplotlib.org/devdocs/devel/coding_guide.html#documentation) and fill out the form to the best of your ability.

**PR Summary**
- Please use a title that describes the bug being fixed or the feature being implemented-for example "Raises ValueError on Non-Numeric Input to set_xlim"
- Please provide at least 1-2 sentences describing the pull request in detail.

- Please provide at least 1-2 sentences describing the pull request.
- What type of PR is this?
- [ ] library bug fix
- [ ] documentation bug fix
Expand All @@ -23,5 +24,4 @@ Thank you so much for your PR! To help us review, please make use of our
- [ ] change the API in a backward-incompatible way: documented it in [doc/api/api_changes.rst](../doc/api/api_changes)
Copy link
Copy Markdown
Member

@WeatherGod WeatherGod Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documented --> document

Copy link
Copy Markdown
Member

@WeatherGod WeatherGod Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nevermind, I see it is all supposed to be past tense.


We understand that PRs can sometimes feel like a guantlet, especially as the reviews start coming in. Please let us know
Copy link
Copy Markdown
Contributor

@anntzer anntzer Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gauntlet

the line wrapping is a bit weird.

if the reviews are unclear or the recommended next step is too ardous, and if you'd like help in addressing a reveiwers
comments. And ping us if you've been waiting too long to hear back on your PR!
if the reviews are unclear or the recommended next step is overwhelming, or if you would like help in addressing a reviewer's comments. And please ping us if you've been waiting too long to hear back on your PR!