Skip to content

FIX: disable pixel snap in eventplot for large event counts #31856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EdenRochmanSharabi wants to merge 1 commit into from
+23 −0
Closed

FIX: disable pixel snap in eventplot for large event counts #31856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,8 @@ def eventplot(self, positions, orientation='horizontal', lineoffsets=1,
linestyle=linestyle)
self.add_collection(coll, autolim=False)
coll._internal_update(kwargs)
if 'snap' not in kwargs and len(positions) > 100:
coll.set_snap(False)
colls.append(coll)

if len(positions) > 0:
Expand Down
21 changes: 21 additions & 0 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8190,6 +8190,27 @@ def test_eventplot_errors(err, args, kwargs, match):
plt.eventplot(*args, **kwargs)


def test_eventplot_snap_threshold():
"""Snap is disabled when there are more than 100 event groups."""
fig, ax = plt.subplots()
positions = [np.random.rand(5) for _ in range(150)]
colls = ax.eventplot(positions)
for coll in colls:
assert coll.get_snap() is False

fig2, ax2 = plt.subplots()
positions_small = [np.random.rand(5) for _ in range(50)]
colls_small = ax2.eventplot(positions_small)
for coll in colls_small:
assert coll.get_snap() is not False

fig3, ax3 = plt.subplots()
positions_explicit = [np.random.rand(5) for _ in range(150)]
colls_explicit = ax3.eventplot(positions_explicit, snap=True)
for coll in colls_explicit:
assert coll.get_snap() is True


def test_bar_broadcast_args():
fig, ax = plt.subplots()
# Check that a bar chart with a single height for all bars works.
Expand Down
Loading