FIX: disable pixel snap in eventplot for large event counts#31856
FIX: disable pixel snap in eventplot for large event counts#31856EdenRochmanSharabi wants to merge 1 commit into
Conversation
When more than 100 event groups are plotted, the Agg renderer snaps thin lines to the nearest pixel. With many closely spaced rows the rounding can collapse distinct events onto the same pixel, making them invisible. Disable snap automatically above 100 groups unless the caller passes snap explicitly. Closes matplotlib#20243
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
|
This does not seem to consider the discussion on the previous PR, nor does it use our PR summary template. @EdenRochmanSharabi since you are opening many PRs in many projects it looks like you are aiming for quantity over quality, like driven by AI. I’m going to close this in line with our policy. |
|
Hi @rcomer, I understand your concern. I've been exploring smaller fixes across a few projects to get a feel for which ones I'd like to contribute to more deeply. In my experience, when I've tried tackling larger issues, the PRs often sit without any review for months, which can be discouraging. Starting with smaller, well-scoped fixes felt like a better way to learn the codebase and the review process. That said, I should have used the PR template and looked more carefully at the previous PR's discussion. That's on me. If you'd be open to it, I'm happy to reopen with those addressed. |
When more than 100 event groups are plotted, the Agg renderer snaps thin lines to the nearest pixel. With many closely spaced rows the rounding can collapse distinct events onto the same pixel, making them invisible.
This disables snap automatically above 100 groups unless the caller passes
snapexplicitly.A previous attempt (#30053) was closed.
Closes #20243