Skip to content

tests: extend QtAgg figureoptions coverage (follow-up to #30128) #30587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YQ157 wants to merge 9 commits into
base: main
Choose a base branch
from
+403 −0
Open

tests: extend QtAgg figureoptions coverage (follow-up to #30128) #30587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
64f485d
feat: add ability to toggle legend in the figure options dialog box
ritvi-alagusankar Jun 2, 2025
56ce769
test: add test case to toggle legend visibility
ritvi-alagusankar Jul 1, 2025
592b087
style: format ruff
ritvi-alagusankar Jul 1, 2025
99049b7
tests: broaden QtAgg figureoptions test coverage
YQ157 Sep 23, 2025
aedc923
style: refactor colormap API usage
YQ157 Sep 23, 2025
7a135ad
Merge branch 'matplotlib:main' into fix-legend-test-coverage
YQ157 Sep 23, 2025
b2a3ffa
style: refactor colormap API usage
YQ157 Sep 23, 2025
42ee881
Merge branch 'fix-legend-test-coverage' of https://github.com/YQ157/m…
YQ157 Sep 23, 2025
3ad3e68
tests: cover mappables len==4 case in QtAgg figureoptions
YQ157 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/matplotlib/backends/qt_editor/figureoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def convert_limits(lim, converter):
)
for name, axis in axis_map.items()
]),
('Legend visible', axes.legend_ is not None),
('(Re-)Generate automatic legend', False),
]

Expand Down Expand Up @@ -196,6 +197,7 @@ def apply_callback(data):
title = general.pop(0)
axes.set_title(title)
generate_legend = general.pop()
legend_visible = general.pop()

for i, (name, axis) in enumerate(axis_map.items()):
axis_min = general[4*i]
Expand Down Expand Up @@ -256,6 +258,10 @@ def apply_callback(data):
if new_legend:
new_legend.set_draggable(draggable)

# toggle legend visibility
if axes.legend_ is not None:
axes.legend_.set_visible(legend_visible)

# Redraw
figure = axes.get_figure()
figure.canvas.draw()
Expand Down
Loading
Loading