tests: extend QtAgg figureoptions coverage (follow-up to #30128)#30587
tests: extend QtAgg figureoptions coverage (follow-up to #30128)#30587YQ157 wants to merge 9 commits into
Conversation
85ae698 to
a1434f3
Compare
|
Only |
|
Hi maintainers, The only failing check is "Python 3.12 on ubuntu-24.04-arm", where test_webagg appears to time out after 120 s. |
|
All checks have passed ✅ This is not only my first contribution to Matplotlib, but also my first contribution to an open-source project. Thanks a lot! |
|
I'm a bit confused by the PR title; there are more files changed here than just tests. Also, please don't reformat entire files; that makes it difficult to see what your actual changes are. |
760b427 to
aedc923
Compare
…atplotlib into fix-legend-test-coverage
Thanks for the feedback! I’ve reverted the accidental reformatting, so the diff should now be clean. |
|
If this PR is meant to go on top of #30128 then I think we need to bring that to a conclusion before reviewing this one. |
Add a second callback invocation with a 4-tuple mappable (label, cmap, low, high) to exercise the `elif len(...) == 4` branch in `figure_edit`. Use fresh copies of the input blocks since the callback mutates them.
Thanks for the clarification! You are correct — this PR is based on #30128, and its purpose is to add the missing tests needed for its CI checks to pass. Please let me know how I can help. |
This PR extends the test suite for the QtAgg figureoptions dialog,
addressing coverage gaps reported on PR #30128 (Codecov) and related to issue #11109.
What’s included:
The underlying implementation was originally proposed in #30128.
This PR only adds tests (with minimal supporting changes), to ensure more complete coverage
and to make it easier for maintainers to review and merge the fix.
Refs #30128, #11109
ℹ️ Note: This is my first open-source contribution.
It directly addresses the same problem described in issue #11109, which was marked as a good first issue.