Skip to content

Mark some Builder providers as Experimental #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphr merged 1 commit into from
Jan 27, 2019
Merged

Mark some Builder providers as Experimental #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions processor/src/main/java/org/mapstruct/ap/spi/FreeBuilderAccessorNamingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

import javax.lang.model.element.ExecutableElement;

import org.mapstruct.util.Experimental;

/**
* Accessor naming strategy for FreeBuilder.
* FreeBuilder adds a lot of other methods that can be considered as fluent setters. Such as:
Expand All @@ -24,6 +26,7 @@
*
* @author Filip Hrisafov
*/
@Experimental("The FreeBuilder accessor naming strategy might change in a subsequent release")
public class FreeBuilderAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

@Override
Expand Down
3 changes: 3 additions & 0 deletions processor/src/main/java/org/mapstruct/ap/spi/ImmutablesAccessorNamingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,16 @@

import javax.lang.model.element.ExecutableElement;

import org.mapstruct.util.Experimental;

/**
* Accesor naming strategy for Immutables.
* The generated Immutables also have a from that works as a copy. Our default strategy considers this method
* as a setter with a name {@code from}. Therefore we are ignoring it.
*
* @author Filip Hrisafov
*/
@Experimental("The Immutables accessor naming strategy might change in a subsequent release")
public class ImmutablesAccessorNamingStrategy extends DefaultAccessorNamingStrategy {

@Override
Expand Down
3 changes: 3 additions & 0 deletions processor/src/main/java/org/mapstruct/ap/spi/ImmutablesBuilderProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import javax.lang.model.element.PackageElement;
import javax.lang.model.element.TypeElement;

import org.mapstruct.util.Experimental;

/**
* Builder provider for Immutables. A custom provider is needed because Immutables creates an implementation of an
* interface and that implementation has the builder. This implementation would try to find the type created by
Expand All @@ -21,6 +23,7 @@
*
* @author Filip Hrisafov
*/
@Experimental("The Immutables builder provider might change in a subsequent release")
public class ImmutablesBuilderProvider extends DefaultBuilderProvider {

private static final Pattern JAVA_JAVAX_PACKAGE = Pattern.compile( "^javax?\\..*" );
Expand Down