Skip to content

Mark some Builder providers as Experimental#1692

Merged
filiphr merged 1 commit into
mapstruct:masterfrom
filiphr:mark-some-components-with-experimental
Jan 27, 2019
Merged

Mark some Builder providers as Experimental#1692
filiphr merged 1 commit into
mapstruct:masterfrom
filiphr:mark-some-components-with-experimental

Conversation

@filiphr

@filiphr filiphr commented Jan 19, 2019

Copy link
Copy Markdown
Member

Mark the Immutables BuilderProvider and AccessorNamingStrategy and the FreeBuilderAccessorNamingStrategy as Experimental.

Was not entirely sure whether we should do this or not.

…e FreeBuilderAccessorNamingStrategy as Experimental
@filiphr filiphr requested a review from sjaakd January 19, 2019 09:06

@sjaakd sjaakd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filiphr filiphr merged commit 884ca25 into mapstruct:master Jan 27, 2019
@filiphr filiphr deleted the mark-some-components-with-experimental branch January 27, 2019 20:21
@filiphr

filiphr commented Jan 27, 2019

Copy link
Copy Markdown
Member Author

Thanks for the review @sjaakd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants