Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Integrate new STS provider with S3 and pro#13877

Merged
dfangl merged 2 commits into
iam/moto-migrationfrom
daniel/unc-275
Mar 4, 2026
Merged

Integrate new STS provider with S3 and pro#13877
dfangl merged 2 commits into
iam/moto-migrationfrom
daniel/unc-275

Conversation

@dfangl

@dfangl dfangl commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

This PR fixes remaining integration issues with pro and S3 - this should result in all remaining tests green.

Changes

  • Integrate S3 with the new STS provider (looking up access keys for verifying presigned URLs)
  • Handle transitive tags regardless of tags in the current request (small regression caught by pro tests)

Tests

All tests in community (and pro) should now be green

Related

Closes UNC-275
Closes UNC-270

@dfangl dfangl requested a review from pinzon as a code owner March 3, 2026 15:43
@dfangl dfangl added this to the 2026.03 milestone Mar 3, 2026
@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Mar 3, 2026
@github-actions

github-actions Bot commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 104 tests   21 217 ✅  6m 23s ⏱️
     1 suites   1 887 💤
     1 files         0 ❌

Results for commit 9bdbfab.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 4s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 9bdbfab.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files      2 suites   1h 8m 58s ⏱️
1 703 tests 1 557 ✅ 146 💤 0 ❌
1 705 runs  1 557 ✅ 148 💤 0 ❌

Results for commit 9bdbfab.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 27m 50s ⏱️
1 727 tests 1 584 ✅ 143 💤 0 ❌
1 733 runs  1 584 ✅ 149 💤 0 ❌

Results for commit 9bdbfab.

♻️ This comment has been updated with latest results.

@dfangl dfangl requested a review from simonrw March 4, 2026 12:41
@dfangl dfangl force-pushed the iam/moto-migration branch from d87db73 to 449d4e1 Compare March 4, 2026 13:04
@alexrashed alexrashed removed their request for review March 4, 2026 13:25
@dfangl dfangl force-pushed the iam/moto-migration branch from 449d4e1 to 2770dfd Compare March 4, 2026 13:48
bentsku
bentsku reviewed Mar 4, 2026
View reviewed changes

@bentsku bentsku left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the S3 part, but I think it has already been merged with #13856, and this one is adding the actual logic inside get_access_key_by_id that is then used by S3 pre-signed, is that right?

@dfangl

dfangl commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

Yes @bentsku , the S3 part was already in the other part. This just amends the new util method to also integrate with the new STS provider, previously it was just IAM user access keys.

@dfangl dfangl removed request for silv-io and simonrw March 4, 2026 19:00
pinzon
pinzon approved these changes Mar 4, 2026
View reviewed changes

@pinzon pinzon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍

@dfangl dfangl merged commit cd148f9 into iam/moto-migration Mar 4, 2026
33 checks passed
@dfangl dfangl deleted the daniel/unc-275 branch March 4, 2026 19:10
dfangl added a commit that referenced this pull request Mar 6, 2026
@dfangl
Integrate new STS provider with S3 and pro (#13877)
ebebad1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bentsku bentsku bentsku left review comments

@pinzon pinzon pinzon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

2026.03

Development

Successfully merging this pull request may close these issues.

3 participants

@dfangl @pinzon @bentsku