This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Cleanup IAM provider#13856
Merged
Merged
Conversation
pinzon
approved these changes
Feb 26, 2026
Comment on lines
+41
to
+45
| @dataclasses.dataclass | ||
| class AccessKeyInfo: | ||
| access_key_id: str | ||
| secret_access_key: str | ||
| session_token: str | None = None |
Member
There was a problem hiding this comment.
I wonder if we should put this class in models.py
Member
Author
There was a problem hiding this comment.
It’s not really a model of the service, just a typed return value of that method. I think as long as we don’t store it it does not have to be in the models class :)
dfangl
added a commit
that referenced
this pull request
Mar 4, 2026
dfangl
added a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR performs some cleanup on the IAM provider. It removes all moto related code, imports, patches and so on.
We also refactor S3 to avoid it's reliance on the IAM moto implementation (which would be incorrect now anyway).
Another thing this PR fixes is the new IAM provider in pro - the iam policies json was missing from the built wheel, so it was missing in pro.
It is now properly included.
There are also some test fixes related to the proper ordering of attached policies.
Changes
Tests
All IAM tests should now pass
Related
Closes UNC-299
Prepares UNC-275