This repository was archived by the owner on Mar 23, 2026. It is now read-only.
IAM: Migrate OIDC Operations#13800
Merged
Merged
Conversation
LocalStack Community integration with Pro 2 files 2 suites 3m 1s ⏱️ For more details on these failures, see this check. Results for commit c1880ac. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files ± 0 5 suites ±0 11m 47s ⏱️ - 2h 33m 34s For more details on these failures, see this check. Results for commit c1880ac. ± Comparison against base commit 00594bb. ♻️ This comment has been updated with latest results. |
dfangl
approved these changes
Feb 24, 2026
Comment on lines
+3158
to
+3163
| if host.startswith("https://"): | ||
| host = host[8:] | ||
| elif host.startswith("http://"): | ||
| host = host[7:] | ||
| # Remove trailing slash | ||
| host = host.rstrip("/") |
Member
There was a problem hiding this comment.
nit: urlparse or a simple split on "://" might have been easier, but it's fine 😅
Comment on lines
+3381
to
+3401
| # Handle marker-based pagination | ||
| if marker: | ||
| # Marker is the index (0-based) as a string | ||
| try: | ||
| start_index = int(marker) | ||
| except ValueError: | ||
| start_index = 0 | ||
|
|
||
| # Apply pagination | ||
| if max_items: | ||
| end_index = start_index + max_items | ||
| paginated_tags = tags[start_index:end_index] | ||
| is_truncated = end_index < len(tags) | ||
| else: | ||
| paginated_tags = tags[start_index:] | ||
| is_truncated = False | ||
|
|
||
| response = ListOpenIDConnectProviderTagsResponse( | ||
| Tags=paginated_tags, | ||
| IsTruncated=is_truncated, | ||
| ) |
Member
There was a problem hiding this comment.
We should use the PaginatedList here!
dfangl
added a commit
that referenced
this pull request
Feb 26, 2026
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
dfangl
added a commit
that referenced
this pull request
Feb 26, 2026
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
dfangl
added a commit
that referenced
this pull request
Mar 4, 2026
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
dfangl
added a commit
that referenced
this pull request
Mar 6, 2026
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As per the IAM internalization project. This pr implements the operations and resources required for OpenID connector provider management in the IAM service.
Changes
thumbprint_list, tags
Tests
All the recently added tests for OIDC must be pass.
Merge after #13794