Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

IAM: Implement SAML provider operations#13794

Merged
dfangl merged 2 commits into
iam/moto-migrationfrom
cris/unc-235
Feb 24, 2026
Merged

IAM: Implement SAML provider operations#13794
dfangl merged 2 commits into
iam/moto-migrationfrom
cris/unc-235

Conversation

@pinzon

@pinzon pinzon commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

As per the internalization project, this PR adds the implementation of the operations related to the SAML Provider features to the IAM Service Provider.

Changes

  • New dataclass SAMLProvider in models.py with fields: arn, name, saml_metadata_document, create_date,
    valid_until, tags
  • Storage of saml_providers by ARN in the store
  • New method _parse_saml_metadata_expiration to extract certificate expiration from SAML metadata XML
  • New method _get_saml_provider_arn to generate provider ARN
  • New method _get_saml_provider_or_raise to retrieve provider or raise NoSuchEntityException
  • Service operation added: create_saml_provider
  • Service operation added: get_saml_provider
  • Service operation added: list_saml_providers
  • Service operation added: update_saml_provider
  • Service operation added: delete_saml_provider
  • Service operation added: tag_saml_provider
  • Service operation added: untag_saml_provider
  • Service operation added: list_saml_provider_tags

Tests

  • Tests related to this feature must be green

Merge after #13793

@pinzon pinzon added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 18, 2026
@pinzon pinzon marked this pull request as ready for review February 18, 2026 21:43
@pinzon pinzon requested a review from dfangl as a code owner February 18, 2026 21:43
@github-actions

github-actions Bot commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown

LocalStack Community integration with Pro

  2 files    2 suites   2m 54s ⏱️
518 tests 438 ✅ 70 💤 10 ❌
520 runs  438 ✅ 72 💤 10 ❌

For more details on these failures, see this check.

Results for commit 16b7651.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 123 tests  ±0   21 252 ✅ ±0   6m 21s ⏱️ +4s
     1 suites ±0    1 871 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 16b7651. ± Comparison against base commit 00594bb.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 2s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 16b7651. ± Comparison against base commit 00594bb.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   11m 16s ⏱️ - 2h 34m 5s
542 tests  - 5 485  458 ✅  - 4 949  70 💤  - 517  14 ❌  - 19 
548 runs   - 5 485  458 ✅  - 4 949  76 💤  - 517  14 ❌  - 19 

For more details on these failures, see this check.

Results for commit 16b7651. ± Comparison against base commit 00594bb.

♻️ This comment has been updated with latest results.

@dfangl dfangl force-pushed the iam/moto-migration branch from 49e13e2 to cbcd0f4 Compare February 19, 2026 18:50
@bentsku bentsku removed their request for review February 20, 2026 13:56
@pinzon pinzon added this to the 4.14 milestone Feb 20, 2026
@pinzon pinzon force-pushed the cris/unc-235 branch 2 times, most recently from 8458dde to 4add3ee Compare February 20, 2026 20:10
@pinzon pinzon force-pushed the cris/unc-235 branch 2 times, most recently from f84976b to 16b7651 Compare February 20, 2026 23:51
@pinzon pinzon mentioned this pull request Feb 21, 2026
Merged
dfangl
dfangl approved these changes Feb 24, 2026
View reviewed changes

@dfangl dfangl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just rebased it and did a minor modification to the store access!

@dfangl dfangl merged commit b0ed13b into iam/moto-migration Feb 24, 2026
5 of 7 checks passed
@dfangl dfangl deleted the cris/unc-235 branch February 24, 2026 17:06
dfangl added a commit that referenced this pull request Feb 26, 2026
@pinzon @dfangl
IAM: Implement SAML provider operations (#13794)
c55eac2 
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
dfangl added a commit that referenced this pull request Feb 26, 2026
@pinzon @dfangl
IAM: Implement SAML provider operations (#13794)
674559e 
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
dfangl added a commit that referenced this pull request Mar 4, 2026
@pinzon @dfangl
IAM: Implement SAML provider operations (#13794)
d5733e6 
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
dfangl added a commit that referenced this pull request Mar 6, 2026
@pinzon @dfangl
IAM: Implement SAML provider operations (#13794)
7fcf82c 
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dfangl dfangl dfangl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

2 participants

@pinzon @dfangl