This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 23220 ]] Ensure mouseUp is sent to image objects out of browse mode#7568
Merged
Merged
Conversation
… mode This patch ensures that the mouseUp message is sent to image objects when the tool is image or pointer and the mouse button is released inside the image. Previously, use of an uninitialized rectangle (srect) caused the wrong message to be almost always sent.
8e310ae to
eb723a4
Compare
runrevmark
suggested changes
May 24, 2021
runrevmark
left a comment
Contributor
There was a problem hiding this comment.
Can you tweak the commit message to reflect the bug fix (I know it came from having to fix a compile error - but its better to document as the thing it fixes):
[[ Bug 23220 ]] Ensure mouseUp is sent to image objects out of browse mode
This patch ensures that the mouseUp message is sent to image objects when the
tool is image or pointer and the mouse button is released inside the image. Previously,
use of an uninitialized rectangle (srect) caused the wrong message to be almost always
sent.
eb723a4 to
81162cc
Compare
Contributor
Author
|
@runrevmark Thanks, done :) |
runrevmark
approved these changes
May 24, 2021
Contributor
|
@livecode-vulcan review ok 81162cc |
Contributor
|
💙 review by @runrevmark ok 81162cc |
livecode-vulcan
added a commit
that referenced
this pull request
May 24, 2021
[[ Bug 23220 ]] Ensure mouseUp is sent to image objects out of browser mode This patch ensures that the mouseUp message is sent to image objects when the tool is image or pointer and the mouse button is released inside the image. Previously, use of an uninitialized rectangle (srect) caused the wrong message to be almost always sent.
Contributor
|
😞 test failure 81162cc
|
Contributor
Author
|
@livecode-vulcan retry 81162cc |
livecode-vulcan
added a commit
that referenced
this pull request
May 24, 2021
[[ Bug 23220 ]] Ensure mouseUp is sent to image objects out of browser mode This patch ensures that the mouseUp message is sent to image objects when the tool is image or pointer and the mouse button is released inside the image. Previously, use of an uninitialized rectangle (srect) caused the wrong message to be almost always sent.
Contributor
|
😎 test success 81162cc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that the mouseUp message is sent to image objects when the
tool is image or pointer and the mouse button is released inside the image. Previously,
use of an uninitialized rectangle (srect) caused the wrong message to be almost always
sent.