Merge pull request #7568 from livecodepanos/bugfix-23220

livecodepanos · web-flow · commit 58acf2ba809c · 2021-05-24T22:30:40.000+03:00
[[ Bug 23220 ]] Ensure mouseUp is sent to image objects out of browse mode
diff --git a/docs/notes/bugfix-23220.md b/docs/notes/bugfix-23220.md
@@ -0,0 +1 @@
+# Ensure clicking in an image rect in pointer mode does not send mouseRelease instead of a mouseUp message
diff --git a/engine/src/image.cpp b/engine/src/image.cpp
@@ -465,11 +465,11 @@ Boolean MCImage::mup(uint2 which, bool p_release)
 		static_cast<MCMutableImageRep *>(m_rep) -> image_mup(which))
 		return True;
 
+	MCRectangle srect;
+	MCU_set_rect(srect, mx, my, 1, 1);
 	switch(getstack() -> gettool(this))
 	{
 	case T_BROWSE:
-		MCRectangle srect;
-		MCU_set_rect(srect, mx, my, 1, 1);
 		if (!p_release && maskrect(srect))
 			message_with_args(MCM_mouse_up, which);
 		else

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure clicking in an image rect in pointer mode does not send mouseRelease instead of a mouseUp message`