[[ Log ]] log command and logMessage global property#6782
Conversation
5cb2e85 to
665eed2
Compare
|
So this patch gives us: However, as discussed offline it would be nice if it could be extended to allow: This would allow things like: I had suggested previously that we could make the So perhaps, instead, we should keep [ The above approach would mean that we don't need to worry about forward compatibility of |
|
So this seems to be failing when running the testsuite through the server engine (the log tests are failing too, but that's a separate thing). The individual test lines which are usual output to the test log file are being emitted to stdout/stderr. |
| else | ||
| TestDiagnostic it | ||
| end if | ||
| TestAssert "log message" && tLogMessage, word 1 to -1 of line 1 of it is true |
There was a problem hiding this comment.
@runrevmark are you sure there's an issue on server? We dump the log on failure. I think there might be an issue with the test not handling the mix of stdout and stderr we get in shell here. I'm thinking that rather than testing for true we generate a uuid and check it's somewhere in the output.
There was a problem hiding this comment.
Well there's definitely a difference between what is emitted when running the tests in the standalone engine compared to the server engine (the log tests fail in the standalone test phase, but doesn't end up meaning all the individual 'ok' lines get dumped to stdout/stderr at the end, as far as I can see at least...)
There was a problem hiding this comment.
I don't think it's running under the server engine is it? I can't access more than the normal output for standalone test phase then the dumped log
There was a problem hiding this comment.
Hah - sorry - you are right - not sure where I thought I saw server ;) So, yes - this is just because the log tests are failing :D
This patch adds tests for using the log command when the log message is empty, and when it is set to the name of a public handler and a private handler.
|
@livecode-vulcan review ok 318de49 |
|
💙 review by @runrevmark ok 318de49 |
[[ Log ]] log command and logMessage global property
|
😎 test success 318de49
|
No description provided.