[[ Log ]] Add tests for log command

livecodeali · montegoulding · commit 318de49a7d37 · 2019-05-09T08:41:46.000+10:00
This patch adds tests for using the log command when the log message
is empty, and when it is set to the name of a public handler and a
private handler.
diff --git a/tests/_testlib.livecodescript b/tests/_testlib.livecodescript
@@ -610,18 +610,21 @@ on TestRepeat pDesc, pHandler, pTarget, pTimeOut, pParamsArray
 	end if
 end TestRepeat
 
-on TestRunStack pOptions, pStackFilePath
+command TestRunStack pOptions, pStackFilePath, pArgs
 	local tEnginePath
 	set the itemDelimiter to ":"
 	put item 2 of the address into tEnginePath
 
 	local tCommand
-	put format("\"%s\" %s \"%s\"", tEnginePath, pOptions, pStackFilePath) into tCommand
+	put format("\"%s\" %s \"%s\" %s", tEnginePath, pOptions, pStackFilePath, pArgs) into tCommand
 
 	local tOutput
 	put shell(tCommand) into tOutput
-
-	return the result
+   if the result is not empty then
+      return the result for error
+   else
+      return tOutput for value
+   end if
 end TestRunStack
 
 function TestIsInStandalone
diff --git a/tests/lcs/core/debugging/_log.lc b/tests/lcs/core/debugging/_log.lc
@@ -0,0 +1,18 @@
+#!
+
+set the logMessage to $0
+log $1
+quit 0
+
+command log pValue
+    write "Error: this should not be called" & return to stderr
+    quit 1
+end log
+
+private command logPublic pValue
+    write pValue & return to stdout
+end logPublic
+
+private command logPrivate pValue
+    write pValue & return to stdout
+end logPrivate
diff --git a/tests/lcs/core/debugging/_log.livecodescript b/tests/lcs/core/debugging/_log.livecodescript
@@ -0,0 +1,36 @@
+script "CoreDebugging_Log"
+/*
+Copyright (C) 2017 LiveCode Ltd.
+
+This file is part of LiveCode.
+
+LiveCode is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License v3 as published by the Free
+Software Foundation.
+
+LiveCode is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
+
+on startup
+    set the logMessage to $2
+    log $3
+    quit 0
+end startup
+
+command log pValue
+    write "Error: this should not be called" & return to stderr
+    quit 1
+end log
+
+command logPublic pValue
+    write pValue & return to stdout
+end logPublic
+
+private command logPrivate pValue
+    write pValue & return to stdout
+end logPrivate
diff --git a/tests/lcs/core/debugging/log.livecodescript b/tests/lcs/core/debugging/log.livecodescript
@@ -0,0 +1,56 @@
+﻿script "log"
+/*
+Copyright (C) 2019 LiveCode Ltd.
+
+This file is part of LiveCode.
+
+LiveCode is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License v3 as published by the Free
+Software Foundation.
+
+LiveCode is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
+
+on TestLog
+   local tStackToRun
+   put the effective filename of me into tStackToRun
+   set the itemdelimiter to slash
+   if the environment is "server" then
+      put "_log.lc" into item -1 of tStackToRun
+   else
+      put "_log.livecodescript" into item -1 of tStackToRun
+   end if
+
+   local tOptions
+   if the environment contains "command line" then
+      put "-ui" into tOptions
+   end if
+   set the itemdelimiter to comma
+
+   local tArgs, tResult, tUUID
+   put uuid() into tUUID
+   repeat for each item tLogMessage in "logPublic,logPrivate"
+      put tLogMessage && tUUID into tArgs
+      TestRunStack tOptions, tStackToRun, tArgs
+      if the result is not empty then
+         TestDiagnostic the result
+      else
+         TestDiagnostic it
+      end if
+      TestAssert "log message" && tLogMessage, tUUID is in it
+   end repeat
+
+   put quote & quote && tUUID into tArgs
+   TestRunStack tOptions, tStackToRun, tArgs
+   if the result is not empty then
+      TestDiagnostic the result
+   else
+      TestDiagnostic it
+   end if
+   TestAssert "log message" && tLogMessage, tUUID is not in it
+end TestLog
