Skip to content

feat: make httpx client timeout configurable via config dict #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owlas merged 1 commit into from
Jul 17, 2025
Merged

feat: make httpx client timeout configurable via config dict #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lightdash/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,18 @@ class Client:
instance_url (str): The URL of your Lightdash instance
access_token (str): The access token for authentication
project_uuid (str): The UUID of the project to interact with
config (Dict[str, Any], optional): Configuration options. Supported keys:
- timeout (float): The timeout in seconds for HTTP requests. Defaults to 30.0
"""
def __init__(self, instance_url: str, access_token: str, project_uuid: str):
def __init__(self, instance_url: str, access_token: str, project_uuid: str, config: Optional[Dict[str, Any]] = None):
self.instance_url = instance_url.rstrip('/')
self.access_token = access_token
self.project_uuid = project_uuid

# Extract config values with defaults
config = config or {}
self.timeout = config.get('timeout', 30.0)

self.models = Models(self)

def _log_request(
Expand Down Expand Up @@ -91,7 +98,7 @@ def _make_request(
"Authorization": f"ApiKey {self.access_token}",
"Accept": "application/json",
},
timeout=30.0
timeout=self.timeout
) as client:
response = client.request(
method=method,
Expand Down