Skip to content

feat: make httpx client timeout configurable via config dict#11

Merged
owlas merged 1 commit into
mainfrom
feat/configurable-timeout
Jul 17, 2025
Merged

feat: make httpx client timeout configurable via config dict#11
owlas merged 1 commit into
mainfrom
feat/configurable-timeout

Conversation

@owlas
Copy link
Copy Markdown
Contributor

@owlas owlas commented Jul 17, 2025

Summary

  • Changed Client.init to accept optional config dict parameter
  • Moved timeout from direct parameter to config dict entry
  • Default timeout remains 30.0 seconds if not specified

Benefits

  • More flexible configuration approach
  • Allows for future configuration options to be added easily
  • Cleaner API for passing multiple config values

Usage Example

client = Client(
    instance_url="https://example.lightdash.cloud",
    access_token="your-token", 
    project_uuid="your-project-uuid",
    config={"timeout": 60.0}  # Custom timeout
)

Test plan

  • Verify client works with default timeout when config not provided
  • Verify client uses custom timeout when specified in config
  • Ensure backward compatibility

🤖 Generated with Claude Code

- Changed Client.__init__ to accept optional config dict parameter
- Moved timeout from direct parameter to config dict entry
- Default timeout remains 30.0 seconds if not specified
- Allows for future configuration options to be added easily

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@owlas owlas merged commit 4bfd5c1 into main Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant