Skip to content

Support symlinks on Windows when core.symlinks=true #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethomson merged 12 commits into from
Nov 15, 2018
Merged

Support symlinks on Windows when core.symlinks=true #4713

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b8bdffb
cmake: increase WIN32_WINNT to Vista
ethomson Jul 2, 2018
3077126
win32: use GetFinalPathNameByHandle directly
ethomson Jul 3, 2018
7b6875f
checkout tests: don't use GetFinalPathNameByHandle
ethomson Jul 2, 2018
e4ac400
checkout tests: test symlinks based on support, not platform
ethomson Jul 2, 2018
204cce6
win32: add symbolic link support
ethomson Jul 3, 2018
8533c80
repo tests: ensure core.symlinks is set correctly
ethomson Jul 3, 2018
df1733d
checkout tests: ensure readlink succeeds
ethomson Jul 16, 2018
628dae8
tests: provide symlink support helper function
ethomson Oct 19, 2018
b433a22
win32: emulate Git for Windows in symlink support
ethomson Oct 19, 2018
820e1e9
repository: load_config for non-repo configs
ethomson Oct 20, 2018
3f0caa1
repo::init tests: refactor global config path override
ethomson Oct 20, 2018
da500cc
symlink tests: test symbolic links on windows
ethomson Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
cmake: increase WIN32_WINNT to Vista 
Increase the WIN32_WINNT level to 0x0600, which enables support for new
APIs from Windows 6.0 (Vista).  We had previously set this to 0x0501,
which was Windows XP.  Although we removed XP support many years ago,
there was no need to update this level previously.  We're doing so now
explicitly so that we can get support for the `CreateSymbolicLink` API.
  • Loading branch information
@ethomson
ethomson committed Oct 20, 2018
commit b8bdffb55b4b249ab445d420038a1a97a8dcab5e
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ FILE(GLOB SRC_H

# On Windows use specific platform sources
IF (WIN32 AND NOT CYGWIN)
ADD_DEFINITIONS(-DWIN32 -D_WIN32_WINNT=0x0501)
ADD_DEFINITIONS(-DWIN32 -D_WIN32_WINNT=0x0600)

IF(MSVC)
SET(WIN_RC "win32/git2.rc")
Expand Down