Skip to content

Support symlinks on Windows when core.symlinks=true #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethomson merged 12 commits into from
Nov 15, 2018
Merged

Support symlinks on Windows when core.symlinks=true #4713

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b8bdffb
cmake: increase WIN32_WINNT to Vista
ethomson Jul 2, 2018
3077126
win32: use GetFinalPathNameByHandle directly
ethomson Jul 3, 2018
7b6875f
checkout tests: don't use GetFinalPathNameByHandle
ethomson Jul 2, 2018
e4ac400
checkout tests: test symlinks based on support, not platform
ethomson Jul 2, 2018
204cce6
win32: add symbolic link support
ethomson Jul 3, 2018
8533c80
repo tests: ensure core.symlinks is set correctly
ethomson Jul 3, 2018
df1733d
checkout tests: ensure readlink succeeds
ethomson Jul 16, 2018
628dae8
tests: provide symlink support helper function
ethomson Oct 19, 2018
b433a22
win32: emulate Git for Windows in symlink support
ethomson Oct 19, 2018
820e1e9
repository: load_config for non-repo configs
ethomson Oct 20, 2018
3f0caa1
repo::init tests: refactor global config path override
ethomson Oct 20, 2018
da500cc
symlink tests: test symbolic links on windows
ethomson Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repo tests: ensure core.symlinks is set correctly 
Ensure that `core.symlinks` is set correctly.  By default, it is unset,
but it is explicitly set to `false` if the platform was detected to not
support symlinks during repository initialization.
  • Loading branch information
@ethomson
ethomson committed Oct 20, 2018
commit 8533c80dfb4c09c4b19aa40756ffae99595c9b6b
13 changes: 13 additions & 0 deletions tests/repo/init.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,19 @@ void test_repo_init__detect_ignorecase(void)
"core.ignorecase", found_without_match ? true : GIT_ENOTFOUND);
}

void test_repo_init__detect_symlinks(void)
{
struct stat st;
bool no_symlinks;

no_symlinks = (p_symlink("target", "link") < 0 ||
p_lstat("link", &st) < 0 ||
! (S_ISLNK(st.st_mode)));
Copy link
Copy Markdown
Member

@pks-t pks-t Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to have a common helper function to detect symlink support which unifies these three lines here and in "checkout::index".

Copy link
Copy Markdown
Member Author

@ethomson ethomson Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and done.


assert_config_entry_on_init(
"core.symlinks", no_symlinks ? false : GIT_ENOTFOUND);
}

void test_repo_init__detect_precompose_unicode_required(void)
{
#ifdef GIT_USE_ICONV
Expand Down