Skip to content

Support vararg constructors #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff5 merged 2 commits into from
Aug 27, 2022
Merged

Support vararg constructors #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b5ab2
Support vararg constructors
tpoliaw Jul 26, 2022
79a1738
Update NEWS for GH-201
jeff5 Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ New Features
variable (GH-128).

- Under PR GH-101, the matching of sequence arguments to the parameters of
Java methods is improved. A Java varargs parameter does not match a final
sequence in the call if an array parameter could do so. (Thanks Peter
Holloway.)
Java methods is improved (and in constructors under GH-201). A Java
varargs parameter does not match a final sequence in the call if an array
parameter could do so. (Thanks Peter Holloway.)

- array.array itemsize of unsigned types is now the same as their signed
counterparts, where previously it was mostly double. Internal
Expand All @@ -39,7 +39,7 @@ New Features


Jython 2.7.3b2-DEV Bugs fixed
- [ GH- ]
- [ GH-201 ] Support vararg constructors

Jython 2.7.3b1 Bugs fixed
- [ GH-192 ] PyString with non-byte value in formatting of collections
Expand Down
2 changes: 1 addition & 1 deletion src/org/python/core/PyReflectedConstructor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public PyReflectedConstructor(Constructor<?> c) {
}

private ReflectedArgs makeArgs(Constructor<?> m) {
return new ReflectedArgs(m, m.getParameterTypes(), m.getDeclaringClass(), true);
return new ReflectedArgs(m, m.getParameterTypes(), m.getDeclaringClass(), true, m.isVarArgs());
}

public void addConstructor(Constructor<?> m) {
Expand Down