Skip to content

Support vararg constructors#201

Merged
jeff5 merged 2 commits into
jython:masterfrom
tpoliaw:vararg_constructor
Aug 27, 2022
Merged

Support vararg constructors#201
jeff5 merged 2 commits into
jython:masterfrom
tpoliaw:vararg_constructor

Conversation

@tpoliaw
Copy link
Copy Markdown
Contributor

@tpoliaw tpoliaw commented Jul 26, 2022

Checking if constructors are vararg methods allows autoboxing to be used for classes such as

public class Foo {
    public Foo(String name, int... numbers) {
        // ...
    }
}

@jeff5
Copy link
Copy Markdown
Member

jeff5 commented Aug 26, 2022 •
edited
Loading

I was petty sure without reading it that we wouldn't merge this in v2.7.3 as it missed the beta and there isn't a b2.

It's so small and innocent-looking though, and the natural sequel to #101, that I'm tempted to risk it in the rc1. I'll take a look.

@jeff5
Copy link
Copy Markdown
Member

jeff5 commented Aug 27, 2022

We'll ignore the codespell failure. (It learned some new misspellings while we were not looking.)

@jeff5 jeff5 merged commit f17fc25 into jython:master Aug 27, 2022
@tpoliaw
Copy link
Copy Markdown
Contributor Author

tpoliaw commented Aug 27, 2022

Thanks for looking at this, and accepting it after the beta release.

@tpoliaw tpoliaw deleted the vararg_constructor branch August 27, 2022 15:01
@tpoliaw
Copy link
Copy Markdown
Contributor Author

tpoliaw commented Nov 30, 2022

Always the most innocent-looking changes that catch you out. I shot myself in the foot with this one as it exposed #221.

This was referenced Oct 26, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpoliaw @jeff5