Fix some failures using wildfly-swarm profile#424
Merged
arjantijms merged 1 commit intojavaee-samples:masterfrom Nov 20, 2017
Merged
Fix some failures using wildfly-swarm profile#424arjantijms merged 1 commit intojavaee-samples:masterfrom
arjantijms merged 1 commit intojavaee-samples:masterfrom
Conversation
Contributor
|
Thanks! Looks great. I'll wait for travis to clear before merging, but looks okay! |
Contributor
Author
|
Great. Your solution looks much better than mine and is the actual fix for the actual error. Thanks! |
Contributor
Author
|
Oopps it fails as it tries to compile the project alone first. I think we unfortunately need to declare that variable in the test-utils project. Duplicate variable but will work... |
Contributor
Author
|
Will update branch on Monday. |
…arquillian and wildfly swarm version. Additionally, cut the dependency from test-utils to parent to avoid unwanted added dependencies
f814cdb to
361f55a
Compare
Contributor
Author
|
Can't believe, 5 hours to execute these tests and 3 still left :-0 |
Contributor
Author
|
@arjantijms ready to go! |
Contributor
It's indeed quite slow. I guess it's due to Travis being a free service and doesn't give you much cycles. |
Contributor
\o/ |
Contributor
Author
|
Thanks very much @arjantijms ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-->by upgrading upgrading arquillian and wildfly swarm version. Additionally, cut the dependency from test-utils to parent to avoid unwanted added dependencies
Here we go @arjantijms !
Thanks a lot!