Skip to content

Fix some failures using wildfly-swarm profile - #424

Merged
arjantijms merged 1 commit into
javaee-samples:masterfrom
juangon:SWARM-1675_2
Nov 20, 2017
Merged

arjantijms merged 1 commit into
javaee-samples:masterfrom
juangon:SWARM-1675_2

Conversation

@juangon

@juangon juangon commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

-->by upgrading upgrading arquillian and wildfly swarm version. Additionally, cut the dependency from test-utils to parent to avoid unwanted added dependencies

Here we go @arjantijms !

Thanks a lot!

@arjantijms

Copy link
Copy Markdown
Contributor

Thanks! Looks great. I'll wait for travis to clear before merging, but looks okay!

@juangon

juangon commented Nov 17, 2017

Copy link
Copy Markdown
Contributor Author

Great. Your solution looks much better than mine and is the actual fix for the actual error. Thanks!

@juangon

juangon commented Nov 17, 2017

Copy link
Copy Markdown
Contributor Author

Oopps it fails as it tries to compile the project alone first. I think we unfortunately need to declare that variable in the test-utils project. Duplicate variable but will work...

@juangon

juangon commented Nov 17, 2017

Copy link
Copy Markdown
Contributor Author

Will update branch on Monday.

…arquillian and wildfly swarm version. Additionally, cut the dependency from test-utils to parent to avoid unwanted added dependencies
@juangon

juangon commented Nov 20, 2017

Copy link
Copy Markdown
Contributor Author

Can't believe, 5 hours to execute these tests and 3 still left :-0

@juangon

juangon commented Nov 20, 2017

Copy link
Copy Markdown
Contributor Author

@arjantijms ready to go!

@arjantijms

Copy link
Copy Markdown
Contributor

Can't believe, 5 hours to execute these tests and 3 still left :-0

It's indeed quite slow. I guess it's due to Travis being a free service and doesn't give you much cycles.

@arjantijms

Copy link
Copy Markdown
Contributor

@arjantijms ready to go!

\o/

@arjantijms
arjantijms merged commit e8c9ed7 into javaee-samples:master Nov 20, 2017
@juangon

juangon commented Nov 20, 2017

Copy link
Copy Markdown
Contributor Author

Thanks very much @arjantijms !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants