Skip to content

Fix mypy linting issue in dedupreloaded#14942

Merged
krassowski merged 1 commit into
ipython:mainfrom
krassowski:fix-deduperreload.py-mypy
Jul 19, 2025
Merged

Fix mypy linting issue in dedupreloaded#14942
krassowski merged 1 commit into
ipython:mainfrom
krassowski:fix-deduperreload.py-mypy

Conversation

@krassowski
Copy link
Copy Markdown
Member

As noticed in #14939 and #14941

@krassowski krassowski marked this pull request as ready for review July 19, 2025 09:24
@krassowski krassowski modified the milestones: 9.5, 8.38 Jul 19, 2025
@krassowski krassowski merged commit 4d0c438 into ipython:main Jul 19, 2025
16 of 18 checks passed
@krassowski krassowski deleted the fix-deduperreload.py-mypy branch July 19, 2025 09:31
@lumberbot-app
Copy link
Copy Markdown
Contributor

lumberbot-app Bot commented Jul 19, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 8.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4d0c438d617e49b77d68cd98208f7b2d371a1381
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14942: Fix mypy linting issue in dedupreloaded'
  1. Push to a named branch:
git push YOURFORK 8.x:auto-backport-of-pr-14942-on-8.x
  1. Create a PR against branch 8.x, I would have named this PR:

"Backport PR #14942 on branch 8.x (Fix mypy linting issue in dedupreloaded)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app lumberbot-app Bot added the Still Needs Manual Backport Added My MrMeeseeks when a backport fails. Help by backporting it, solving conflicts, send PR. label Jul 19, 2025
@krassowski krassowski modified the milestones: 8.38, 9.5 Jul 19, 2025
@krassowski krassowski removed the Still Needs Manual Backport Added My MrMeeseeks when a backport fails. Help by backporting it, solving conflicts, send PR. label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant