Remove pytest-asyncio pin#14939
Merged
Merged
Conversation
Collaborator
Author
|
It looks like this was already started in #14784. |
Collaborator
Author
|
The to be on the previous line. If you move it then darker in pre-commit moves it back and makes the surrounding formatting even worse. 😄
|
krassowski
approved these changes
Jul 19, 2025
Member
krassowski
left a comment
There was a problem hiding this comment.
Thank you @ianthomas23! Fixing the mypy issue in #14941.
krassowski
added a commit
that referenced
this pull request
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downstream
ipykerneltests using the recent changes on themainbranch there are failing here withCurrently we pin
pytest-asyncio<0.22here whereas inipykernelwe usepytest-asyncio>=0.23.5so the two pins are not compatible. Both projects do not pinpytestso use8.4.1.According to the
pytest-asynciochangelog for compatibility withpytest>=8we need at leastpytest-asyncio>=0.23.5.If I remove the
pytest-asynciopin locally then all tests pass on both Ubuntu and macOS, so this PR is seeing what happens without the pin on the full CI matrix.