feat(segment-button): Add --indicator-height property to segment button#19653
Merged
brandyscarney merged 8 commits intoJan 23, 2020
Merged
feat(segment-button): Add --indicator-height property to segment button#19653brandyscarney merged 8 commits into
brandyscarney merged 8 commits into
Conversation
brandyscarney
approved these changes
Oct 23, 2019
Member
|
Thank you for the PR! I'm working on some big changes to segment right now as part of this but I will get this in: #19036. 🙂 |
liamdebeasi
approved these changes
Nov 7, 2019
brandyscarney
approved these changes
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Each
ion-segment-buttoninside anion-segmenthas an indicator right below it with a height of 2px. You can customize the color of the indicator but not the height.What is the new behavior?
Setting the
--indicator-heightcss variable on anion-segment-buttonsets its height. The default value is 2px.Does this introduce a breaking change?