feat(segment): implement iOS 13 segment with animation#19036
Merged
Conversation
* Remove close button * update tests * update tests * add build
updates e2e test for toolbar
adds `--indicator-box-shadow` variable adds global hover variables: `--ion-toolbar-segment-background-hover` `--ion-toolbar-segment-color-hover` updates tests to use these vars
and allowing user to override the opacity easier
they were not applied anyway
allows it to work with `--color-checked`
liamdebeasi
reviewed
Nov 11, 2019
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Is it possible to disable scrolling while swiping on iOS? If I hold down and swipe horizontally I can also scroll vertically.
|
|
||
| const { x, y } = pointerCoord(detail.event); | ||
|
|
||
| ripple.addRipple(x, y).then(remove => remove()); |
Contributor
There was a problem hiding this comment.
So I'm actually trying this on an Android device and the ripple is being applied to the starting element not the ending element.
Steps to repro:
- Load the Basic test on Android.
- Start on "Free" and and swipe to "Top".
- Release finger. Notice that the ripple is applied to "Free" and not "Top".
- removes opacity on hover - adds a CSS property to set indicator transform - sets activated class on segment to transform the indicator with css, removing JS requirement
move the indicator to that element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 READY FOR REVIEW 🔍
Docs PR: ionic-team/ionic-docs#1072
Dev Build
5.0.0-dev.201911072022.7909b12Changes
Closes #18663
Screenshots
iOS
Material Design