Enable SocketCAN interface tests in GitHub CI - #1484
Merged
Conversation
Previously, it was not permitted to restart an already started period send task for SocketCAN. This behavior was changed in PR hardbyte#1440. This commit adjusts the test to reflect this change.
Collaborator
Author
|
For future reference: As of PR #1440 the default behavior for restarting Cyclic Send Tasks for SocketCAN was changed from raising an exception to not raising an exception. The test was still testing for an exception to be raised, which is no longer the case. |
Collaborator
Author
|
@zariiii9003 I think this should be fine now. Please check if the CI integration and the tests suit you. |
zariiii9003
reviewed
Jan 14, 2023
zariiii9003
approved these changes
Jan 14, 2023
zariiii9003
left a comment
Collaborator
There was a problem hiding this comment.
Really nice addition, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1479
I still need to investigate why the CPython tests fail.