Describe the bug
The SocketCAN tests are only executed when the environment variable TEST_SOCKETCAN is present. The variable was likely introduced in the Travis CI environment and passed into test execution via tox. I noticed that it is no longer present in the current GitHub Workflow CI environment. This causes several of the SocketCAN tests to be skipped.
Updating the pipeline would include two things:
- Executing
test/open_vcan.sh on Linux machines
- Adding the environment variable
TEST_SOCKETCAN or removing it and simply executing these tests for all Linux systems
I know that workflow scripts have root permission on the GitHub runners. But I wasn't able to check if they also have capability NET_ADMIN to open vcan interfaces. Additionally, I wasn't sure if I could and didn't want to open a PR and mess with the workflow pipeline before opening an issue first. @zariiii9003 was the variable removed on purpose? If not, I can volunteer a patch, but I wanted to ask for some feedback first.
Describe the bug
The SocketCAN tests are only executed when the environment variable
TEST_SOCKETCANis present. The variable was likely introduced in the Travis CI environment and passed into test execution via tox. I noticed that it is no longer present in the current GitHub Workflow CI environment. This causes several of the SocketCAN tests to be skipped.Updating the pipeline would include two things:
test/open_vcan.shon Linux machinesTEST_SOCKETCANor removing it and simply executing these tests for all Linux systemsI know that workflow scripts have root permission on the GitHub runners. But I wasn't able to check if they also have capability
NET_ADMINto open vcan interfaces. Additionally, I wasn't sure if I could and didn't want to open a PR and mess with the workflow pipeline before opening an issue first. @zariiii9003 was the variable removed on purpose? If not, I can volunteer a patch, but I wanted to ask for some feedback first.