Support repeatable directives - progressive branch#1916
Closed
Support repeatable directives - progressive branch#1916
Conversation
Contributor
|
Thanks for your suggestions and review. It will be great with your support. |
Member
Author
|
See #2015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created this
support_repeatable_directivesbranch to incorporate the great work done in PR #1915Since this work is not complete I wanted to create a long lived central branch that further work could be pushed to.
@dugenkui03 can you base any future work off this branch. We will merge master on to it periodically.
This will allow us to work collaboratively.
The code as is does query repeatable directives
However we need to revisit the SchemaGenerator and
GraphqlXXXtypes so that directives are truly everywhere including SDL types, We also need to put in support insideGraphqlDirectiveitself for the repeatable boolean.References :
#1763
https://github.com/graphql/graphql-spec/pull/472/files