support_repeatable_directives#1986
support_repeatable_directives#1986dugenkui03 wants to merge 3 commits intographql-java:support_repeatable_directivesfrom
Conversation
f4b9d93 to
7280bc4
Compare
7280bc4 to
aff7c04
Compare
|
Note: this is a breaking change. |
bbakerman
left a comment
There was a problem hiding this comment.
We are looking to go into a slightly different direction on this.
We need much of this code (and we need raw grammar support as well)
But I think we will leave the names as is to maximise backwards compatibility (DirectiveContainer vs DirectivesContainer ) and leave the getDirective(name) as a singleton directive fetcher that throws if there is more than 1
We will take some of the code so we appreciate this.
There will be a branch that I will start soon
| default Directive getDirective(String directiveName) { | ||
| default List<Directive> getDirective(String directiveName) { | ||
| return getDirectivesByName().get(directiveName); | ||
| } |
There was a problem hiding this comment.
I think for backwards compatibility I think we should add a getFirstDirective(String name) method. This would get the 0th entry of null if empty
While multiple directives are allowed, I posit that a lot of people will use one mostly.
We also have a choice here - we could make Directive getDirective(String directiveName) be the "get first" and then add a getDirectives(String name) say.
@andimarek - thoughts?
|
See #2015 |
No description provided.