This repository was archived by the owner on May 14, 2026. It is now read-only.
Conversation
xiaozhenliu-gg5
approved these changes
Aug 12, 2020
xiaozhenliu-gg5
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this, do we also need synchronized method?
| public Builder setLock(VariableExpr variableExpr) { | ||
| // This will also prevent declared variables (i.e. setIsDecl(true)) due to their void types. | ||
| Preconditions.checkState( | ||
| TypeNode.isReferenceType(variableExpr.type()), |
Contributor
There was a problem hiding this comment.
Great! it prevents null type also.
Contributor
Author
|
I haven't seen a synchronized method yet, so no. |
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
This should detect if the current version of shared-dependencies, if released as-is, would cause a sampling of downstream client libraries to fail dependency checks. Fixes #177
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.