Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

[ggj] feat: add of and format methods to ResName codegen - #177

Merged
miraleung merged 16 commits into
masterfrom
gp/g5
Aug 14, 2020
Merged

[ggj] feat: add of and format methods to ResName codegen#177
miraleung merged 16 commits into
masterfrom
gp/g5

Conversation

@miraleung

Copy link
Copy Markdown
Contributor

No description provided.

+ " @BetaApi(\"The static create methods are not stable yet and may be changed in the"
+ " future.\")\n"
+ " public static FoobarName ofProjectFoobarBuilder() {\n"
+ " return newProjectFoobarBuilder().setProject(project).setFoobar(foobar).build();\n"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below of***Builder method all has arguments of the setter tokens, is this intended here that we will construct the Builder from the global variable project and foobar instead of passing them in?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Base automatically changed from gp/g4 to master August 14, 2020 23:11
@miraleung
miraleung merged commit 1dd6b18 into master Aug 14, 2020
@miraleung
miraleung deleted the gp/g5 branch August 14, 2020 23:29
suztomo pushed a commit that referenced this pull request Mar 21, 2023
This should detect if the current version of shared-dependencies, if released as-is, would cause a sampling of downstream client libraries to fail dependency checks.

Fixes #177
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* 
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants