Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: do not crash if distribution cannot be found when extracting semver #393

Merged
pradn merged 2 commits into from
Apr 21, 2021
Merged

fix: do not crash if distribution cannot be found when extracting semver #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69dd0da
fix: no longer crash if pubsub distribution cannot be found wqwhen ex…
hannahrogers-google Apr 21, 2021
73b2261
doc: add context to distribution not found exception
hannahrogers-google Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion google/cloud/pubsub_v1/publisher/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@
from google.pubsub_v1 import types as gapic_types
from google.pubsub_v1.services.publisher import client as publisher_client

__version__ = pkg_resources.get_distribution("google-cloud-pubsub").version
try:
__version__ = pkg_resources.get_distribution("google-cloud-pubsub").version
except pkg_resources.DistributionNotFound:
# Distribution might not be available if we are not running from within a
# PIP package.
__version__ = "0.0"

_LOGGER = logging.getLogger(__name__)

Expand Down
7 changes: 6 additions & 1 deletion google/cloud/pubsub_v1/subscriber/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@
from google.pubsub_v1.services.subscriber import client as subscriber_client


__version__ = pkg_resources.get_distribution("google-cloud-pubsub").version
try:
__version__ = pkg_resources.get_distribution("google-cloud-pubsub").version
except pkg_resources.DistributionNotFound:
# Distribution might not be available if we are not running from within
# a PIP package.
__version__ = "0.0"

_BLACKLISTED_METHODS = (
"publish",
Expand Down