This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: do not crash if distribution cannot be found when extracting semver#393
Merged
Conversation
pradn
suggested changes
Apr 21, 2021
pradn
left a comment
Contributor
There was a problem hiding this comment.
Please add some context for when this call can throw.
Contributor
|
Change looks good! Can you please update the PR summary with some context? |
Contributor
Author
Yes, I updated the PR summary and added a doc for context in the PR. Thanks, Prad! |
Contributor
|
Looks good, approved! |
pradn
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where a user is not running from within a pip package, the google-cloud-pubsub distribution might not be available. At the moment this will cause a fatal DistributionNotFound error because in the publisher and subscriber client, we try to extract the distribution version using 'pkg_resources.get_distribution("google-cloud-pubsub").version'.
In the case where a distribution is not found, making the change to set the version to 0.0.