Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix: add missing native image test command to build script#1812

Closed
mpeddada1 wants to merge 1 commit intomainfrom
native-image-build
Closed

fix: add missing native image test command to build script#1812
mpeddada1 wants to merge 1 commit intomainfrom
native-image-build

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

No description provided.

@mpeddada1 mpeddada1 requested review from a team April 9, 2022 00:37
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 9, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2022
Copy link
Copy Markdown
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, adding do not merge label

@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 11, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2022
@mpeddada1
Copy link
Copy Markdown
Contributor Author

Thanks for the review @ansh0l and @suztomo! Would it be okay to merge this PR? The Graalvm job is currently not running in the repo so adding this script will help with debugging #1811

@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented May 23, 2022

Closing since native image changes have been released with #1878

@ansh0l ansh0l closed this May 23, 2022
@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented May 23, 2022

Closing since native image changes have been released with #1878

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants