This repository was archived by the owner on Apr 7, 2026. It is now read-only.
feat(java): relocate SpannerFeature from java-core#1811
Closed
feat(java): relocate SpannerFeature from java-core#1811
Conversation
…nner into testing-native-image
ansh0l
reviewed
Apr 11, 2022
…nner into testing-native-image
Contributor
|
Closing since native image changes have been released with #1878 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves SpannerFeature from java-core to Spanner. Once this PR is merged, we can remove https://github.com/googleapis/java-core/blob/main/native-image-support/src/main/java/com/google/cloud/nativeimage/features/clients/SpannerFeature.java
Note that the Kokoro Native Image job don't run any tests with native image support at the moment. This will be resolved with #1812